Fixes #4794: Fix marketplace blanking after populating #4796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
hannesrudolph
added
the
Issue/PR - Triage
Collaborator
|
@roomote Add a test for this. |
roomote
added a commit
that referenced
this pull request
Jun 17, 2025
- Add tests for displayItems initialization fix that prevents marketplace blanking - Test state management scenarios including filtering, tab switching, and error handling - Verify that displayItems properly falls back to allItems when no filters are active - Test infinite loop prevention and proper state change notifications - Ensure immutability of state objects returned by getState() Addresses comment in PR #4796: #4796 (comment)
dosubot
bot
added
size:L
daniel-lxs
moved this from PR [Draft / In Progress]
to PR [Needs Prelim Review]
in Roo Code Roadmap
Member
|
This looks like it might be a proper fix, I'll move it so I can polish it up if needed |
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
daniel-lxs
approved these changes
Jun 19, 2025
Member
There was a problem hiding this comment.
I was not able to replicate the issue but this change looks like it's good to have. I tested the marketplace and works correctly.
I ran pnpm check-types and pnpm test and didn't find any issues, I'm unsure what's causing the tests to fail on this PR.
Edit: the test needed to be updated to use vitest.
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
daniel-lxs
moved this from PR [Needs Review]
to PR [Needs Prelim Review]
in Roo Code Roadmap
- Fixed state management issue in MarketplaceViewStateManager where displayItems was not properly initialized - Improved handling of marketplace items when no filters are active to ensure all items are displayed - Enhanced initial state loading logic to prevent infinite loops and ensure proper state updates - Fixed getState method to fall back to allItems when displayItems is empty The issue was caused by displayItems being set to an empty array when marketplace items were loaded, even when no filters were applied. This caused the marketplace to appear blank after loading completed.
- Add tests for displayItems initialization fix that prevents marketplace blanking - Test state management scenarios including filtering, tab switching, and error handling - Verify that displayItems properly falls back to allItems when no filters are active - Test infinite loop prevention and proper state change notifications - Ensure immutability of state objects returned by getState() Addresses comment in PR #4796: #4796 (comment)
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
mrubens
approved these changes
Jun 20, 2025
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
cte
pushed a commit
that referenced
this pull request
Jun 24, 2025
Co-authored-by: Daniel Riccio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4794
The issue was caused by displayItems being set to an empty array when marketplace items were loaded,
even when no filters were applied. This caused the marketplace to appear blank after loading completed.
Important
Fixes marketplace blanking issue by ensuring
displayItemsare properly initialized and updated inMarketplaceViewStateManager.displayItemsinitialization inMarketplaceViewStateManagerto prevent marketplace blanking when no filters are active.getStateto ensuredisplayItemsdefaults toallItemsif undefined.MarketplaceViewto prevent infinite loops.MarketplaceViewStateManager.spec.tsto verifydisplayItemsinitialization and state change notifications.displayItemsis never empty whenallItemshas content and no filters are active.This description was created by
for 5ff1732. You can customize this summary. It will automatically update as commits are pushed.